[PATCH] D86074: [ARM][MVE] Tail-predication: check get.active.lane.mask's TC value

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 9 07:47:43 PDT 2020


SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/ARM/MVETailPredication.cpp:624
+    for (auto &I : *BB) {
+      if (I.getOpcode() != Instruction::Add || &I != BTC)
+        continue;
----------------
efriedma wrote:
> Why are we searching the basic block here, instead of just using `dyn_cast<Instruction>(BTC)`?
There was a use for this in the previous version of this patch, to reuse some IR, but it's not necessary anymore in this version, so has been removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86074/new/

https://reviews.llvm.org/D86074



More information about the llvm-commits mailing list