[PATCH] D87326: [ADT] Fix reference invalidation when self referencing a SmallVector

[Nathan James via Phabricator via llvm-commits]

njames93 added a comment.

For the clang tidy naming warnings, is it better to follow the warnings, or the current convention of the file?

I haven't added specific test cases for this, but all ADT Tests did run without a hitch under asan



================
Comment at: llvm/include/llvm/ADT/SmallVector.h:650
 
   void assign(size_type NumElts, const T &Elt) {
     clear();
----------------
The function probably also needs fixing up, but there are 2 issues here, the other being the above FIXME. Would prefer to address all of that in a follow up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87326/new/

https://reviews.llvm.org/D87326