[PATCH] D87285: AMDGPU/GlobalISelemitter Support for predicate code that uses operands

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 9 07:39:52 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:3919
+        for (unsigned i = 0; i < WaitingForNamedOperands; ++i) {
+          auto Name = "pred:" + Twine(Call.Scope) + ":" + TP->getArgName(i);
+          StoreIdxForName[Name.str()] = i;
----------------
Can we put this string generation in a function somewhere? I think this is repeated 2 or 3 times


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87285/new/

https://reviews.llvm.org/D87285



More information about the llvm-commits mailing list