[PATCH] D87361: [SelectionDAG] Add helper guard to automatically insert flags

[Qing Shan Zhang via Phabricator via llvm-commits]

steven.zhang added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:4413
                               SDValue Operand, const SDNodeFlags Flags) {
+  SDNodeFlags NFlags = Flags;
+  if (Inserter && !Inserter->isDisabled())
----------------
This is not right as you override the Flags secretly. How about having another version that didn't have the Flags parameter and we will get it from Inserter. And one version that has the Flags if people really want to set the flags manually.(I wonder if there is such case)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87361/new/

https://reviews.llvm.org/D87361