[PATCH] D86294: [RFC] AMDGPU/GlobalISel: Look through copies in GIM_CheckOpcode

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 9 02:01:12 PDT 2020


foad added a comment.

In D86294#2261887 <https://reviews.llvm.org/D86294#2261887>, @arsenm wrote:

> I think copies that can be ignored should be taken care of by a combiner pass, and the selector should not have to do this

Can you explain how you think this should work for selecting e.g. v_add_lshl where some of the operands can be sgprs? A combiner pass can't remove cross-register-bank copies, can it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86294/new/

https://reviews.llvm.org/D86294



More information about the llvm-commits mailing list