[PATCH] D80713: [AMDGPU] Support disassembly for AMDGPU kernel descriptors

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D80713#2261550 <https://reviews.llvm.org/D80713#2261550>, @rochauha wrote:

> 3 of the test cases - `kd-sgpr.s`, `kd-vgpr.s`, `kd-zeroed-gfx10.s` fail with the //PowerPC// buildbot (http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/53608). From what I understand, these tests should only run if AMDGPU target is built. The `lit.local.cfg` file specifies that.

The PowerPC build bot just means a build bot that is running on a PowerPC host. It actually targets most targets. See the following excerpt from the CMake.

  -- Targeting AArch64
  -- Targeting AMDGPU
  -- Targeting ARM
  -- Targeting AVR
  -- Targeting BPF
  -- Targeting Hexagon
  -- Targeting Lanai
  -- Targeting Mips
  -- Targeting MSP430
  -- Targeting NVPTX
  -- Targeting PowerPC
  -- Targeting RISCV
  -- Targeting Sparc
  -- Targeting SystemZ
  -- Targeting WebAssembly
  -- Targeting X86
  -- Targeting XCore

I've run into this sort of problem before. The issue is almost certainly either a) incorrect assumption about host system endianness, meaning that you've incorrectly/inadvertently assumed the host is little endian, or b) assumed a 64-bit system somewhere. a) is almost certainly the issue here, based on both the test output and build bot name (ppc64*be*). I've skimmed the patch, but can't obviously see where the code is going wrong, but the test output for `kd-zeroed-gfx10.s` suggests it's around bytes 48-52. There may be other issues elsewhere though, since 0 renders the same regardless of size and endianness.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80713/new/

https://reviews.llvm.org/D80713