[PATCH] D86612: [libunwind] Enable the SEH unwinding codepaths if building in MSVC mode

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D86612#2262441 <https://reviews.llvm.org/D86612#2262441>, @compnerd wrote:

> It is definitely possible to disable SEH via `/EHs-` though

Sure, but that's not visible via preprocessor macros as far as I know. (It's not mentioned in https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros, MSVC doesn't support `-E -dM`, and this option doesn't change clang-cl's predefined macros.)

And regardless - if building libunwind for an MSVC environment, the SEH backend (as opposed to the dwarf or SJLJ ones) is the one that makes most sense to enable by default, as far as I can see. I guess you'd theoretically want to be able to enable the dwarf backend as well, but that should probably require more explicit opt-in.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86612/new/

https://reviews.llvm.org/D86612