[PATCH] D87199: [lld-macho] Implement support for PIC

[Jez Ng via Phabricator via llvm-commits]

int3 added a comment.

> It may be clearer if we scan the GOT/LazyPointerSection inside RebaseSection::finalizeContents() for any absolute addresses

Actually, this doesn't really work either, because we need to add the rebases early in order that the `isNeeded()` filtering doesn't filter out RebaseSection. Also there's a fair bit of code duplication in this approach; it essentially mirrors the logic in `NonLazyPointerSectionBase::writeTo()` and `LazyPointerSection::writeTo()`. I don't see a nice solution here...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87199/new/

https://reviews.llvm.org/D87199