[PATCH] D87342: WIP: Plumb TargetTransformInfo into computeKnownBits

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 8 20:38:00 PDT 2020


qcolombet added a comment.

The bulk of the changes are plumbing TTI into the `computeKnownBits` APIs. On top of that, `clang-format` did its magic and there are a lot of changes.



================
Comment at: llvm/unittests/Analysis/ValueTrackingTest.cpp:1078
+                        const DominatorTree *DT, OptimizationRemarkEmitter *ORE,
+                        bool UseInstrInfo) const {
+    if (!isa<Operator>(V))
----------------
This illustrates how the target can put some extract effort on some instructions.


================
Comment at: llvm/unittests/Analysis/ValueTrackingTest.cpp:1202
+                           F->front().getTerminator(), /*DT=*/nullptr,
+                           /*ORE=*/nullptr, /*UseInstrInfo=*/true, &TTI);
+  // We know of one less zero because 512 may have produced a 1 that
----------------
Note: This test illustrates how it would work with a custom TTI but is not commit-able as is because it relies on `BasicTTIImplBase`, which is part of the CodeGen library.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87342/new/

https://reviews.llvm.org/D87342



More information about the llvm-commits mailing list