[PATCH] D87199: [lld-macho] Implement support for PIC

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added a comment.

Is there a funnel point that we know that all the rebase entries will pass through to ensure that we catch them rather than adding them at a couple of sites?



================
Comment at: lld/MachO/SyntheticSections.h:187
+  Location target;
+  BindingEntry(const DylibSymbol *dysym, int64_t addend, Location target)
+      : dysym(dysym), addend(addend), target(std::move(target)) {}
----------------
What do you think of moving `addend` to after `target`?


================
Comment at: lld/MachO/SyntheticSections.h:214
+  Location target;
+  WeakBindingEntry(const Symbol *symbol, int64_t addend, Location target)
+      : symbol(symbol), addend(addend), target(std::move(target)) {}
----------------
Similar


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87199/new/

https://reviews.llvm.org/D87199