[PATCH] D87339: [NFC][ThinLTO] Let llvm::EmbedBitcodeInModule handle serialization.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

Does this rely on the following check in EmbedBitcodeInModule returning true?

  if (!isBitcode((const unsigned char *)Buf.getBufferStart(),
                 (const unsigned char *)Buf.getBufferEnd())) {

I.e. I assume an empty buffer will be !isBitcode? The comments there suggest this is trying to detect whether we have bitcode vs LLVM assembly as input. Might be better to add an explicit check for an empty buffer and expand the comments (along with your current change).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87339/new/

https://reviews.llvm.org/D87339