[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

Dave Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 8 14:15:59 PDT 2020


kastiglione added a comment.

If another project defines `LLVM_ENABLE_WARNINGS` before loading `HandleLLVMOptions`, it seems correct to me that the first one is used. This change ensures the default value of ON is setup at the last possible opportunity, before `LLVM_ENABLE_WARNINGS` is read and acted on.

To answer the question, according to a small sample, there's no warning in the case of redundant `option()`s.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87243/new/

https://reviews.llvm.org/D87243



More information about the llvm-commits mailing list