[PATCH] D85670: [Instruction] Add updateLocationAfterHoist helper

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: llvm/lib/IR/DebugInfo.cpp:717
+    // Avoid making it look like the inlined callee was reached early.
+    setDebugLoc(DebugLoc::get(0, 0, SP));
+  else
----------------
aprantl wrote:
> Should we pick up a scope from the instruction before it to avoid having a hole in that scope's range?
I'd argue that we shouldn't. In this case, I think we want to use a scope that conveys 'you could be anywhere in this function'. The scope from a nearby instruction could be more specific than that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85670/new/

https://reviews.llvm.org/D85670