[PATCH] D86908: [lld-macho] Mark weak symbols in symbol table
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 8 13:47:15 PDT 2020
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lld/MachO/SyntheticSections.cpp:476
// TODO support other symbol types
// TODO populate n_desc
if (auto *defined = dyn_cast<Defined>(entry.sym)) {
----------------
Might wanna adjust this a little?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86908/new/
https://reviews.llvm.org/D86908
More information about the llvm-commits
mailing list