[PATCH] D87301: [IRSim][IROutliner] Adding consistent function attribute merging
Andrew Litteken via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 8 12:19:15 PDT 2020
AndrewLitteken added inline comments.
================
Comment at: llvm/lib/IR/Attributes.cpp:2077
+ setOR<UseSampleProfileAttr>(Base, ToMerge);
+}
----------------
jdoerfert wrote:
> Are we sure we want/need to duplicate this here in addition to the merge rules at the end of `llvm/include/llvm/IR/Attributes.td` ?
We can probably just call `mergeFnAttrs` from this function and merge the attributes from SanitizeAddress separately.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87301/new/
https://reviews.llvm.org/D87301
More information about the llvm-commits
mailing list