[PATCH] D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp accepted this revision.
stefanp added a comment.
This revision is now accepted and ready to land.

This mostly LGTM.
>From my perspective you can add `no-show-raw-insn` on commit.



================
Comment at: llvm/test/CodeGen/PowerPC/pcrel-tls-local-exec.ll:65
+; CHECK-S-NEXT:    paddi r3, r13, y at TPREL, 0
+; CHECK-S-NEXT:    addi r3, r3, 12
+; CHECK-S-NEXT:    blr
----------------
Thank you for adding this test.
I think we should be able to do better here (as we can merge the offset from the `add` into the `paddi`) but I think that should be a separate patch.


================
Comment at: llvm/test/CodeGen/PowerPC/pcrel-tls-local-exec.ll:6
+; RUN:   -mcpu=pwr10 -ppc-asm-full-reg-names --filetype=obj < %s | \
+; RUN:   llvm-objdump --mcpu=pwr10 -dr - | FileCheck %s --check-prefix=CHECK-O
+
----------------
MaskRay wrote:
> Consider `--no-show-raw-insn`
I agree. Please use `no-show-raw-insn`!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83404/new/

https://reviews.llvm.org/D83404