[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

Baptiste Saleil via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 8 11:46:56 PDT 2020


bsaleil added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14298
     llvm::Function *F = CGM.getIntrinsic(ID, ResultType);
-    return Builder.CreateCall(F, {X, Y});
+    return Builder.CreateCall(F, {Y, X});
   }
----------------
Could you add a test case in `clang/test/CodeGen/builtins-ppc-vsx.c` showing that calls to the builtins and calls to `vec_cpsgn` are generated as calls to the `copysign` LLVM intrinsic with the arguments being inverted ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84962/new/

https://reviews.llvm.org/D84962



More information about the llvm-commits mailing list