[PATCH] D87260: [OpenMPOpt][SplitMemTransfer] Can move setup instructions upwards?

[Hamilton Tobon Mosquera via Phabricator via llvm-commits]

hamax97 added a comment.

In D87260#2261012 <https://reviews.llvm.org/D87260#2261012>, @jdoerfert wrote:

> In D87260#2261006 <https://reviews.llvm.org/D87260#2261006>, @hamax97 wrote:
>
>> In D87260#2260098 <https://reviews.llvm.org/D87260#2260098>, @jdoerfert wrote:
>>
>>> Tests?
>>
>> The regression test for this is `hide_mem_transfer_latency.ll`.  But there's still the issue with the `AAManager`, so the test has the fixmes of where the set up instructions should be moved.
>
> But it seems not to include any changes to the test. why not? because this doesn't have an impact without resolving the issue you mentioned?

Exactly, the `mayModify` function always returns `true` at the instruction immediately above the `issue`, so there's no movement.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87260/new/

https://reviews.llvm.org/D87260