[PATCH] D86453: [AArch64] Support conversion between fp16 and fp128

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: compiler-rt/lib/builtins/fp_extend.h:43
 #elif defined SRC_HALF
+#if defined COMPILER_RT_HAS_FLOAT16
+typedef _Float16 src_t;
----------------
MaskRay wrote:
> `#ifdef` ? ditto below
You can mark the comment above as "Done".

_Float16 and uint16_t are different types. Do all the `*hf*` functions change their signatures when `_Float16` is supported?  This still looks strange.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86453/new/

https://reviews.llvm.org/D86453