[PATCH] D86425: [flang][msvc] Avoid range-based for over initializer_list. NFC.

Tim Keith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 8 08:11:39 PDT 2020


tskeith added inline comments.


================
Comment at: flang/include/flang/Common/enum-set.h:40
   constexpr EnumSet(const std::initializer_list<enumerationType> &enums) {
-    for (auto x : enums) {
-      set(x);
+    for (auto It = enums.begin(); It != enums.end(); ++It) {
+      set(*It);
----------------
To match the style of the flang project this should be:
`for (auto it{enums.begin()}; it != enums.end(); ++it) {`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86425/new/

https://reviews.llvm.org/D86425



More information about the llvm-commits mailing list