[PATCH] D87280: [ARM] Try to rematerialize VCTP instructions

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:6144
+  // spill/restore and VPT predication.
+  return isVCTP(&MI);
+}
----------------
This probably wants to check that the VCTP is not predicated.


================
Comment at: llvm/test/CodeGen/Thumb2/LowOverheadLoops/remat-vctp.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=thumbv8.1m -mattr=+mve.fp %s -o - | FileCheck %s
+
----------------
A full triple would be better. I think the ".main" is important.

Otherwise, how come it is still not tail predicated?


================
Comment at: llvm/test/CodeGen/Thumb2/LowOverheadLoops/remat-vctp.ll:4
+
+define hidden void @arm_vdiv_q31_mve(i32* %arg, i32* %arg1, i32* %arg2, i32* %arg3, i32* %arg4, i16 zeroext %arg5) {
+; CHECK-LABEL: arm_vdiv_q31_mve:
----------------
You can remove hidden.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87280/new/

https://reviews.llvm.org/D87280