[PATCH] D87233: [POC][DebugInfo] Use entry values within IR

[David Stenberg via Phabricator via llvm-commits]

dstenb added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:456-458
-  // Entry values can currently only cover the initial register location,
-  // and not any other parts of the following DWARF expression.
-  assert(!IsEmittingEntryValue && "Can't emit entry value around expression");
----------------
Is there test case where we land in this situation? As I understand it we still have the limitation inside DIExpression that it can only cover one operand (the register operand), and if I am not overlooking something we should have finalized the entry value on line 299:

```
    if (isEntryValue())
      finalizeEntryValue();
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87233/new/

https://reviews.llvm.org/D87233