[PATCH] D86344: [FileCheck] Move FileCheck implementation out of LLVMSupport into its own library

[Raphael Isemann via Phabricator via llvm-commits]

teemperor added a comment.

In D86344#2260056 <https://reviews.llvm.org/D86344#2260056>, @chandlerc wrote:

> Somewhat minor post-commit thought, but we now have both a library `FileCheck` and an executable binary `FileCheck` (not to mention the existing confusion of having two `FileCheck.cpp` files).
>
> Might be nice to think about a naming scheme that would reduce these collisions?

It's kinda similar for tablegen, but there we don't have the problem of the executable having a upper camel case name (`LLVMTableGen` and `llvm-tblgen`). Here it's `LLVMFileCheck` and `FileCheck`. Renaming the library would be inconsistent with the other LLVM library names (which have an `LLVM` prefix) and I renaming `FileCheck` seems like a humongous task. We could rename the library to something else though...

For the file name, maybe `FileCheckFrontend.cpp` for the FileCheck executable source?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86344/new/

https://reviews.llvm.org/D86344