[PATCH] D87263: [DWARFYAML] Make the debug_ranges section optional.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 8 00:29:15 PDT 2020
jhenderson added inline comments.
================
Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_ranges.yaml:288
+
+## Test generating and dumping a __debug_ranges section whose size isn't a multiple of address size.
+## This test case is to ensure that when the parser fails, the content of the __debug_ranges section
----------------
This test case doesn't feel like it really belongs as part of this patch. It should be its own patch, since it isn't to do with writing an empty .debug_ranges section, right?
================
Comment at: llvm/test/ObjectYAML/MachO/DWARF-debug_ranges.yaml:292
+
+# RUN: yaml2obj --docnum=2 -DSIZE=3 -DCONTENT='010203' %s | obj2yaml | FileCheck %s --check-prefix=FAILS
+
----------------
Similar comment to D87261 - it might be worth adding a check that the DWARF tag doesn't appear in this case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87263/new/
https://reviews.llvm.org/D87263
More information about the llvm-commits
mailing list