[PATCH] D87272: [lld] Buffer lld::errs() writes

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

> Buffer consecutive writes of one diagnostic

I found this comment confusing, especially given the example, as I thought initially you were buffering instances of the same diagnostic, rather than the writes for a single diagnostic report. Could you change this to "Buffer writes when composing a single diagnostic"? I think that better expresses the situation.



================
Comment at: lld/Common/ErrorHandler.cpp:216
+    if (errorLimit == 0 || errorCount <= errorLimit) {
+      raw_ostream &errs = lld::errs();
+      SmallString<256> buf;
----------------
This code is very similar to the warning code. Can you de-duplicate it with a helper function?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87272/new/

https://reviews.llvm.org/D87272