[PATCH] D86071: [MLIR][OpenMP] Add omp.do operation

Mon Sep 7 13:50:25 PDT 2020

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

@DavidTruby, In general, I was asking whether all clause enumeration values can begin with a Capital letter? Just the reserved keywords would look odd right?

Also, can you mark fixed comments as done?

I guess for the general workshare loop design issues we can have an RFC in discourse. But this patch can go ahead.

================
Comment at: mlir/test/Dialect/OpenMP/ops.mlir:142
+    (memref<i32>) -> ()
+
+
----------------
Nit: extra line.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86071/new/

https://reviews.llvm.org/D86071