[PATCH] D86947: [ms] [llvm-ml] Add support for size queries in MASM

Eric Astor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 7 10:55:26 PDT 2020


epastor marked 2 inline comments as done.
epastor added inline comments.


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:6631
+             .CaseLower("real4", 32)
+             .CaseLower("real8", 64)
+             .Default(0);
----------------
thakis wrote:
> can you cover some more of these with tests, and some more of the keywords (say, lengthof) too?
Done, thanks! This uncovered issues that required some more extensive revisions; apologies for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86947/new/

https://reviews.llvm.org/D86947



More information about the llvm-commits mailing list