[PATCH] D86610: [ELF] Add a new e_machine value EM_CSKY and add some CSKY relocation types

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 7 08:39:35 PDT 2020


MaskRay added a comment.

In D86610#2254135 <https://reviews.llvm.org/D86610#2254135>, @grimar wrote:

> I have no more comment, thanks! Lets see what others think.

Even if this had high chance to be accepted, I think it needs an official approval (even for this binary format patch). For an unknown arch, supporting `EM_*` is fine, but not `R_*_RELATIVE` and its list of relocation types.

There is no need to revert, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86610/new/

https://reviews.llvm.org/D86610



More information about the llvm-commits mailing list