[PATCH] D86071: [MLIR][OpenMP] Add omp.do operation

[David Truby via Phabricator via llvm-commits]

DavidTruby added inline comments.


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:141
+             Variadic<AnyType>:$linear_vars,
+             Variadic<AnyType>:$linear_step_vars,
+             OptionalAttr<ScheduleKind>:$schedule_val,
----------------
kiranchandramohan wrote:
> Is this a single value or a list of values?
it's one step value per element in linear_vars. So a list of values.
The two lists should always be the same length, but I don't think there's a way to enforce it here (it should be enforced later)


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:142-143
+             Variadic<AnyType>:$linear_step_vars,
+             OptionalAttr<ScheduleKind>:$schedule_val,
+             Optional<AnyType>:$schedule_chunk_var,
+             Optional<AnyType>:$collapse_var,
----------------
kiranchandramohan wrote:
> Is there a schedule modifier also?
I'm leaving the schedule modifier for a later patch, as it requires more changes to the OMP.td file. I've added a clarification on this to the commit message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86071/new/

https://reviews.llvm.org/D86071