[PATCH] D87141: [llvm-readobj/elf] - Introduce Relocation<ELFT> helper.

Mon Sep 7 04:49:53 PDT 2020

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, thanks for the work.

================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:215
+  Relocation(const typename ELFT::Rela &R, bool IsMips64EL)
+      : Relocation((const typename ELFT::Rel &)R, IsMips64EL) {
+    Addend = R.r_addend;
----------------
Registering that I am not particularly keen on casting from Rela -> Rel like this (a person in the future could decide to change the Rel constructor to do something with the assumption that it really is always an Elf_Rel here). I don't have any great alternative currently though, without duplicating logic, so am not asking this to change.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87141/new/

https://reviews.llvm.org/D87141