[PATCH] D80713: [AMDGPU] Support disassembly for AMDGPU kernel descriptors

Ronak Chauhan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 7 04:39:41 PDT 2020


rochauha updated this revision to Diff 290241.
rochauha added a comment.

Changes based on comments by @jhenderson

- Used `llvm::cantFail(C.takeError())` to handle error.
- Removed blank lines at the end of test files.
- Streamlined beginning of comments.
- Used split-file tool to separate SGPR and VGPR test cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80713/new/

https://reviews.llvm.org/D80713

Files:
  llvm/include/llvm/Support/AMDHSAKernelDescriptor.h
  llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
  llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.h
  llvm/test/CodeGen/AMDGPU/nop-data.ll
  llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-failure.s
  llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-sgpr.s
  llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-vgpr.s
  llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-zeroed-gfx10.s
  llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-zeroed-gfx9.s
  llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-zeroed-raw.s
  llvm/tools/llvm-objdump/llvm-objdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80713.290241.patch
Type: text/x-patch
Size: 34387 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200907/39ba4a2f/attachment.bin>


More information about the llvm-commits mailing list