[PATCH] D86867: [obj2yaml] Add support for dumping the .debug_str section.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 7 01:22:31 PDT 2020
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, with suggestion.
================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:213
+
+ return RawSec->Flags.getValueOr(ELFYAML::ELF_SHF(0)) != 0;
+ }
----------------
It may be best to introduce a helper variable so that we don't repeat `RawSec->Flags.getValueOr(ELFYAML::ELF_SHF(0))` twice.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86867/new/
https://reviews.llvm.org/D86867
More information about the llvm-commits
mailing list