[PATCH] D87211: [llvm-objcopy] Consolidate and unify version tests

[James Henderson via Phabricator via llvm-commits]

jhenderson requested changes to this revision.
jhenderson added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/strip-version.test:5
-# CHECK-DAG: {{ version }}
-# CHECK-DAG: GNU strip
----------------
I think this is an important aspect of this test - see https://github.com/llvm/llvm-project/commit/e9af7158200643dd3ff0feb062fecd564345366c. It might make sense to add a similar check for objcopy. I kind of hinted at that in the original review, but it never got acted on.


================
Comment at: llvm/test/tools/llvm-objcopy/tool-version.test:8
+# RUN: llvm-install-name-tool --version | FileCheck %s
+# RUN: llvm-strip -V | FileCheck %s
+
----------------
Presumably copy-paste error?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87211/new/

https://reviews.llvm.org/D87211