[PATCH] D86684: [Refactor] Add the SchedHeuristic for Scheduler to allow platform customizing the heuristics

[Qing Shan Zhang via Phabricator via llvm-commits]

steven.zhang added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineScheduler.h:1148
+  // Notify the heuristic to update the internal state after SU is scheduled.
+  UpdateFn update = nullptr;
+  // Initialize the heuristic
----------------
dmgreen wrote:
> These are lowercase because they act like functions, not like variables?
Yes. I add member function to avoid such confusion.


================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:1540
+// Debug use only
+SchedHeuristic *createOnly1Heuristic() {
+  static SchedHeuristic Only1("ONLY1");
----------------
dmgreen wrote:
> You can probably just add an extra tracePick function, removing the need for this heuristic.
Good idea. Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86684/new/

https://reviews.llvm.org/D86684