[PATCH] D86925: [MachineSink] add one more profitable pattern for sinking

[ChenZheng via Phabricator via llvm-commits]

shchenz marked 2 inline comments as done.
shchenz added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineSink.cpp:626
+          return false;
+        LiveRangeShortenCount++;
+      } else {
----------------
qcolombet wrote:
> Instead of counting the number of live-ranges, we should probably count their weights with respect to the related register pressure set.
> 
> E.g., `<smallDef>, <smallDef> = op <BigUse>`
> 
> Maybe each smallDef accounts for 1 register whereas BigUse accounts for 4 registers.
Good idea!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86925/new/

https://reviews.llvm.org/D86925