[compiler-rt] ab68517 - [asan_symbolize] Pass --demangle/--no-demangle instead of --demangle={True,False}

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 6 14:48:09 PDT 2020


Author: Fangrui Song
Date: 2020-09-06T14:44:37-07:00
New Revision: ab68517e6b7e51b84c4b0e813a30258ec1ce5da5

URL: https://github.com/llvm/llvm-project/commit/ab68517e6b7e51b84c4b0e813a30258ec1ce5da5
DIFF: https://github.com/llvm/llvm-project/commit/ab68517e6b7e51b84c4b0e813a30258ec1ce5da5.diff

LOG: [asan_symbolize] Pass --demangle/--no-demangle instead of --demangle={True,False}

`--demangle={True,False}` were accepted but disallowed after llvm-symbolizer's switch to OptTable.
(`--demangle={true,false}` were temporarily supported but they are case sensitive.)

Added: 
    

Modified: 
    compiler-rt/lib/asan/scripts/asan_symbolize.py

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/asan/scripts/asan_symbolize.py b/compiler-rt/lib/asan/scripts/asan_symbolize.py
index 1e06e0d56fb9..1e78cb1b0e77 100755
--- a/compiler-rt/lib/asan/scripts/asan_symbolize.py
+++ b/compiler-rt/lib/asan/scripts/asan_symbolize.py
@@ -89,7 +89,7 @@ def __init__(self, symbolizer_path, default_arch, system, dsym_hints=[]):
 
   def open_llvm_symbolizer(self):
     cmd = [self.symbolizer_path,
-           '--demangle=%s' % demangle,
+           ('--demangle' if demangle else '--no-demangle'),
            '--functions=linkage',
            '--inlines',
            '--default-arch=%s' % self.default_arch]


        


More information about the llvm-commits mailing list