[PATCH] D87123: [ConstantFold] Make areGlobalsPotentiallyEqual less aggressive.

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/test/Assembler/ConstantExprNoFold.ll:47
+; CHECK: @unnamed.cmp = global i1 icmp eq ([0 x i8]* @unnamed.1, [5 x i8]* @unnamed.2)
+ at unnamed.1 = unnamed_addr constant [5 x i8] "asdf\0"
+ at unnamed.2 = unnamed_addr constant [5 x i8] "asdf\0"
----------------
Looks like the precommit checks complain about this. Shouldn't this be `c"...."` for string constants? Also, it seems like escape sequences are not supported by the bitcode parser and `\0` counts as 2 chars.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87123/new/

https://reviews.llvm.org/D87123