[PATCH] D87203: [KillTheDoctor/CMake] Add missing keyword PRIVATE in target_link_libraries

[Daniel Muñoz via Phabricator via llvm-commits]

dmm9 created this revision.
dmm9 added reviewers: chapuni, thakis, ruiu, rnk, hliao.
Herald added subscribers: llvm-commits, mgorny.
Herald added a project: LLVM.
dmm9 requested review of this revision.

Add PRIVATE keyword in target_link_libraries to prevent CMake Error on Windows.

While trying to compile llvm/clang on Windows, the following CMake error occurred. The reason is a missing PUBLIC/PRIVATE/INTERFACE keyword in target_link_libraries.

`CMake Error at utils/KillTheDoctor/CMakeLists.txt:5 (target_link_libraries):

  The keyword signature for target_link_libraries has already been used with
  the target "KillTheDoctor".  All uses of target_link_libraries with a
  target must be either all-keyword or all-plain.
  
  The uses of the keyword signature are here:
  
   * cmake/modules/AddLLVM.cmake:771 (target_link_libraries)

`


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D87203

Files:
  llvm/utils/KillTheDoctor/CMakeLists.txt


Index: llvm/utils/KillTheDoctor/CMakeLists.txt
===================================================================
--- llvm/utils/KillTheDoctor/CMakeLists.txt
+++ llvm/utils/KillTheDoctor/CMakeLists.txt
@@ -3,6 +3,7 @@
   )
 
 target_link_libraries(KillTheDoctor
+  PRIVATE
   LLVMSupport
   psapi
   )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87203.290136.patch
Type: text/x-patch
Size: 303 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200906/cd23ae92/attachment.bin>