[PATCH] D86867: [obj2yaml] Add support for dumping the .debug_str section.

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 6 03:48:18 PDT 2020


Higuoxing added inline comments.


================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:209
+      if (SecName == "debug_str")
+        return !(RawSec->EntSize && (uint64_t)*RawSec->EntSize == 1) ||
+               RawSec->Flags.getValueOr(ELFYAML::ELF_SHF(0)) !=
----------------
jhenderson wrote:
> Can you do this? I think it's nice to be symmetrical with the flags line below.
I mark this as done since this comment is not applied here ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86867/new/

https://reviews.llvm.org/D86867



More information about the llvm-commits mailing list