[PATCH] D76665: [asan] Stop instrumenting user-defined ELF sections

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added a comment.

In D76665#2237050 <https://reviews.llvm.org/D76665#2237050>, @lebedev.ri wrote:

> In D76665#2161919 <https://reviews.llvm.org/D76665#2161919>, @krytarowski wrote:
>
>> In D76665#2140245 <https://reviews.llvm.org/D76665#2140245>, @kcc wrote:
>>
>>> Will adding __attribute__((no_sanitize("address"))) to your global solve the problem you are trying to solve? 
>>> (sorry for being too terse last time)
>>
>> It does not work (last time I checked).
>
> Does not work how?



>> Also GCC does the same thing of not instrumenting user defined sections.



In D76665#2237050 <https://reviews.llvm.org/D76665#2237050>, @lebedev.ri wrote:

> In D76665#2161919 <https://reviews.llvm.org/D76665#2161919>, @krytarowski wrote:
>
>> In D76665#2140245 <https://reviews.llvm.org/D76665#2140245>, @kcc wrote:
>>
>>> Will adding __attribute__((no_sanitize("address"))) to your global solve the problem you are trying to solve? 
>>> (sorry for being too terse last time)
>>
>> It does not work (last time I checked).
>
> Does not work how?
>
>> Also GCC does the same thing of not instrumenting user defined sections.

I cannot get a user defined section uninstrumented without the proposed patch. Elements in such sections are not in consecutive order. This is a known problem and fixed by GCC in a similar way to this patch here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76665/new/

https://reviews.llvm.org/D76665