[PATCH] D87190: [CMake][TableGen] Remove dead CMake version checks
Raul Tambre via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Sep 5 08:09:00 PDT 2020
tambre created this revision.
tambre added reviewers: compnerd, phosek.
Herald added subscribers: llvm-commits, mgorny.
Herald added a project: LLVM.
tambre requested review of this revision.
LLVM requires CMake 3.13.4, so remove version checks that are dead code.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D87190
Files:
llvm/cmake/modules/TableGen.cmake
Index: llvm/cmake/modules/TableGen.cmake
===================================================================
--- llvm/cmake/modules/TableGen.cmake
+++ llvm/cmake/modules/TableGen.cmake
@@ -8,9 +8,8 @@
message(FATAL_ERROR "${project}_TABLEGEN_EXE not set")
endif()
- # Use depfile instead of globbing arbitrary *.td(s)
- # DEPFILE is available for Ninja Generator with CMake>=3.7.
- if(CMAKE_GENERATOR STREQUAL "Ninja" AND NOT CMAKE_VERSION VERSION_LESS 3.7)
+ # Use depfile instead of globbing arbitrary *.td(s) for Ninja.
+ if(CMAKE_GENERATOR STREQUAL "Ninja")
# Make output path relative to build.ninja, assuming located on
# ${CMAKE_BINARY_DIR}.
# CMake emits build targets as relative paths but Ninja doesn't identify
@@ -139,8 +138,8 @@
set(${target}_OLD_LLVM_LINK_COMPONENTS ${LLVM_LINK_COMPONENTS})
set(LLVM_LINK_COMPONENTS ${LLVM_LINK_COMPONENTS} TableGen)
- # CMake-3.9 doesn't let compilation units depend on their dependent libraries.
- if(NOT (CMAKE_GENERATOR STREQUAL "Ninja" AND NOT CMAKE_VERSION VERSION_LESS 3.9) AND NOT XCODE)
+ # CMake doesn't let compilation units depend on their dependent libraries on some generators.
+ if(NOT CMAKE_GENERATOR STREQUAL "Ninja" AND NOT XCODE)
# FIXME: It leaks to user, callee of add_tablegen.
set(LLVM_ENABLE_OBJLIB ON)
endif()
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87190.290089.patch
Type: text/x-patch
Size: 1338 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200905/be7eb16c/attachment.bin>
More information about the llvm-commits
mailing list