[PATCH] D87099: fix symbol printing on windows
Saleem Abdulrasool via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 4 21:06:39 PDT 2020
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
LGTM with the name change.
================
Comment at: llvm/lib/IR/Mangler.cpp:188
+// Check if the name needs quotes to be safe for the linker to interpret.
+static bool isAcceptableChar(char C) {
+ return (C >= 'a' && C <= 'z') || (C >= 'A' && C <= 'Z') ||
----------------
I think that `isAcceptableChar` is very ambiguous. It can also be difffernent in different contexts. It would be better to rename this to be more precise. Perhaps `canBeUnquotedInDirective`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87099/new/
https://reviews.llvm.org/D87099
More information about the llvm-commits
mailing list