[PATCH] D87166: [GlobalISel] Add G_UNMERGE(Cst) -> Cst1, Cst2, ... combine

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 4 15:49:25 PDT 2020


qcolombet marked an inline comment as done.
qcolombet added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:1623-1624
+  MachineInstr *SrcInstr = MRI.getVRegDef(SrcReg);
+  if (SrcInstr->getOpcode() != TargetOpcode::G_CONSTANT)
+    return false;
+  // Break down the big constant in smaller ones.
----------------
arsenm wrote:
> Should also handle G_FCONSTANT
Good catch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87166/new/

https://reviews.llvm.org/D87166



More information about the llvm-commits mailing list