[PATCH] D86611: GlobalISel: Combine `op undef, x` to 0

Fri Sep 4 13:50:01 PDT 2020

paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

LGTM now that I realized I just misread the code here

================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/combine-shl.mir:4
+---
+name:            test_combine_shl_undef_x_s32
+body:             |
----------------
volkan wrote:
> paquette wrote:
> > A testcase where the G_IMPLICIT_DEF has more than one use would be good?
> Another user wouldn't have any impact on this case. Could you explain why that would be good?
Oh, I misread the code. I thought you were replacing the G_IMPLICIT_DEF for some reason when I first read this. :P

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86611/new/

https://reviews.llvm.org/D86611