[PATCH] D87148: [ImplicitNullCheck] Handle Nonzero faulting pages and complex addressing

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 4 13:35:49 PDT 2020


anna planned changes to this revision.
anna added a comment.

While working on a follow-up change, I realized we don't need to separate out whether we're handling simple or complex addressing mode based on whether we fault in zero page or not. Both are orthogonal issues. The reason I coupled them is because we still need a way to get the "total constant address" *if it exists* and make a distinction between when we succeeded to get one versus when there was no such constant address apart from the offset.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87148/new/

https://reviews.llvm.org/D87148



More information about the llvm-commits mailing list