[PATCH] D86233: [LangRef] Define maynotprogress attribute

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 4 12:06:39 PDT 2020


hfinkel added a comment.

In D86233#2256872 <https://reviews.llvm.org/D86233#2256872>, @lebedev.ri wrote:

> FWIW `maynotprogress` reads worse to me, because my first interpretation/reading was `if it progresses, it's ub`, i.e. `it may not (as in, shall not) progress` instead of `might not make progress`

Funny. I was just thinking about this too. We really want this to read "might not progress". Maybe we should just name it that. mightnotprogress. 'may' is just too ambiguous.

Atmn, sorry for the churn. Sometimes naming is hard ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86233/new/

https://reviews.llvm.org/D86233



More information about the llvm-commits mailing list