[PATCH] D86909: [lld-macho] Initial support for common symbols

Fri Sep 4 10:31:57 PDT 2020

int3 added a comment.

@MaskRay -- I split the common vs non-common symbol handling into D86910 <https://reviews.llvm.org/D86910>. Sorry if that made it confusing... I think it covers all those cases you mentioned, aside from

> common.o archive.a (archive.a has a common) - Is the regular definition in archive.a fetched?

I will add that.

> common0.o common1.o - the larger size is picked. the larger alignment is picked.

Unlike lld-ELF, ld64 actually just picks the larger size, so I've emulated that here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86909/new/

https://reviews.llvm.org/D86909