[PATCH] D86233: [LangRef] Define mayprogress attribute

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 4 09:28:29 PDT 2020


jdoerfert added a comment.

In D86233#2256699 <https://reviews.llvm.org/D86233#2256699>, @hfinkel wrote:

> In D86233#2256648 <https://reviews.llvm.org/D86233#2256648>, @RalfJung wrote:
>
>> I understand. But this is not how the word "may" is usually used. When I say "you may do X", that typically implies that usually, X is not a thing you may do.
>> This can certainly be explained away, but the first impression people are going to have before reading the docs is likely going to be wrong.
>
> I agree. maynotprogress is more self explanatory.

It may do something, it may not do something, sure we can rename it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86233/new/

https://reviews.llvm.org/D86233



More information about the llvm-commits mailing list