[PATCH] D84589: [CodeMoverUtils] Add optional data dependence checks using Alias Analysis

[rithik sharma via Phabricator via llvm-commits]

RithikSharma marked 4 inline comments as done.
RithikSharma added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/CodeMoverUtils.cpp:250
+  if (CallInst *CI = dyn_cast<CallInst>(&I)) {
+    for (Value *Op : CI->arg_operands())
+      if (Op->getType()->isPointerTy()) {
----------------
bmahjour wrote:
> I think the call itself should also go into the MemLocs vector.
CallInst returns none memory location, which won't be useful to find dependence info and we may have to skip it so I did not add it into the MemLocs in the first place. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84589/new/

https://reviews.llvm.org/D84589