[PATCH] D87093: [AMDGPU] Workaround for LDS Misalignment bug on GFX10

Mirko Brkusanin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 4 05:23:51 PDT 2020


mbrkusanin added a comment.

In D87093#2254677 <https://reviews.llvm.org/D87093#2254677>, @arsenm wrote:

> Can you add a comment to hasLDSMisalignedBug with what specifically is broken? Is b64 broken too?

Is the updated description enough or do you prefer an explicit list of all instructions for hasLDSMisalignedBug? Something like:

  // Hardware requires natural alignment for the following:
  // ds_read/write_b64/96/128
  // flat_load/store_dwordx2/3/4

b64 is affected be we currently use ds_read2_b32/write2_b32 instructions. We could potentially relax restrictions for b64 the same way it was done for b96/128 to make it more consistent.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87093/new/

https://reviews.llvm.org/D87093



More information about the llvm-commits mailing list